Sebastian "Sebbie" Silbermann
Sebastian "Sebbie" Silbermann
> Yeah, for sure! Added another CodeSandbox demo here that showcases all three: [codesandbox.io/p/devbox/react-style-precedence-bug-rendertostring-rendertostaticmarkup-rendertopipeablestream-z9zmcl?file=%2Findex.js%3A3%2C1-5%2C26](https://codesandbox.io/p/devbox/react-style-precedence-bug-rendertostring-rendertostaticmarkup-rendertopipeablestream-z9zmcl?file=%2Findex.js%3A3%2C1-5%2C26) Thank you. This wasn't using React 19 but React 18. Though it doesn't change much in...
Fixed: > Thank you for the clarification in the docs! This makes much more sense now 😄 -- https://github.com/reactjs/react.dev/pull/6908#issuecomment-2128159797
`react-is` is another candidate for this. `ReactIs.isElement` will also not work if you use React 19 with an earlier `react-is` (like `recharts` did) or vice versa. The fix is usually...
Some design system libraries need at least support for `isElement` (can be moved to `react`) and `isValidElementType` (should be moved to renderers). You oftentimes find APIs were either element types...
> Another prominent use case is Jest snapshot testing, as reported in https://github.com/facebook/react/pull/28813#issuecomment-2077326950. A version mismatch might break those because [they rely on react-is](https://github.com/jestjs/jest/blob/main/packages/pretty-format/src/plugins/ReactElement.ts?rgh-link-date=2024-05-24T20%3A12%3A14Z). I think what `pretty-format` needs is...
> Good use of spread operator but no, that only applies to the instance of Line The idea would be that you'd use `MyLine` throughout your codebase. You'd gain more...
> it is on the element from this Babel plugin- so maybe Material components aren't built with this plug-in? Component libraries need to apply this transform? I thought this was...
> "Need to"? No. Just pointing out that the file name filtering won't work if this meta info isn't available. No of course we don't "need to" in a literal...
> Wow, I didn't realize that was even valid TypeScript. Same reaction I always have when I stumble over this once a year in product code. But apparently [this is...
Fixed in https://github.com/facebook/react/pull/29670