Samuel Nicholas
Samuel Nicholas
OK so I had run into some trouble verifying the OSX build which forced me to re-think the approach I was taking. I was trying to do things in piecemeal,...
> Thanks! > > Overall, I love the direction this PR is going! I've skimmed through the code and it's mostly looking good, although, I haven't had a chance yet...
> cmake 3.22.1 I found the problem with my code: ``` $ Added in version 3.27. ``` [cmake-documentation](https://cmake.org/cmake/help/latest/manual/cmake-generator-expressions.7.html#list-expressions) I'll come up with a different way of doing that thing. Cheers...
> but I got the same issue @dsnopek I really appreciate you testing and providing the logs. I've replaced the offending generator expressions. I've also downloaded and tested with the...
> I did some amount of line-by-line comparison, but it's tricky, because so much is provided by CMake out-of-the-box. For example, there's practically nothing in `android.cmake`, but it's fine because...
> scons uses builtin clang while my nix cmake uses g++13: That's really interesting, I will try installing gcc on my mac mini and see if it has similar detection...
> You may not have the same experience. I used `nix` cmake specifically. Nix is very big on encapsulation, and if it used the system clang instead of shipping its...
OMG!!! yay, I've been sick for the last three days, this cheers me up immensely. :D
> -Wno-anonymous-struct // Supress warnings for structs Does this work for you? I've searched through documentation for gcc and cant find that flag. Put it into [godbolt.org](https://godbolt.org/z/4eaEEr4qc) and it says...
I think this should be merged. Even though we're aiming for feature _and interface_ parity, even without the option displayed it still adds something missing from the cmake build that...