Samuel Nicholas
Samuel Nicholas
> Why are you specifying both `use_mingw=yes` and `use_llvm=yes`? Aren't those supposed to be mutually exclusive (using either GCC or clang, but not both)? They aren't mutually exclusive, llvm/clang can...
> In general, I think we should follow Godot's lead, and if Godot is handling this in a particular way, then we should handle it that way too. I was...
> Since this this cmake solution tracks [PR#1598](https://github.com/godotengine/godot-cpp/pull/1598) I have in the godot-cpp repo, until it is merged it requires the godot-cpp module be pointed to the right revision. Locally...
> I was going to update the template to Godot 4.4 soon anyways since it should be backwards compatible all the way. That would also update Godot-cpp. I think I...
I've updated godot-cpp submodule in this PR for the latest cherry picks in 4.4 as they are highly desired. I minimised the solution too, rather than try to educate or...
> Hey @enetheru sorry for taking so long to respond to your last message. Can this PR be merged if I understand you correctly? yeah
Looks like I have to fix up the test case
Because of the changes, the CI stopped working, so I needed to overhaul the test/CMakeLists.txt to consider the changes, and reduced the cmake code dramatically.
Again to aid with verification, here is a [google doc](https://docs.google.com/spreadsheets/d/1aUjib11P9CfcMK7P5WhdRIs80jMO9mGPK4RbMlSccCM/edit?usp=sharing) spreadsheet showing the differences in output. If there's anything you'd like me to check please mention it.
I found some issues with my hasty conversion of the test project.