enbrain

Refactor vertex consumer stuff

7

Excluding the vertex method rename. I'm kind of uneasy about that one.

Refactor vertex buffer stuff

8

@apple502j This PR overwrites some of your recent names. I'd like to hear your thoughts.

`VertexConsumer.vertex(double, double, double)` -> `pos`

4

The `vertex(double, double, double)` and `vertex(Matrix4f, float, float, float)` methods should be renamed to `pos`. These methods only specify the position element of the vertex. `pos` makes it in line...

`Program` and `Shader` are confusing

1

Currently, `class_281` is named `net.minecraft.client.gl.Program` and `class_5944` is named `net.minecraft.client.render.Shader`. `class_281` is actually a single shader stage in the graphics pipeline. In other words, it's a shader object that can...

`REGISTRY_CODEC` vs `ENTRY_CODEC` vs `REGISTRY_ENTRY_CODEC`

2

Currently, three different names are used for `Codec`. Fixing inconsistency would be nice. `REGISTRY_CODEC` is used for * `net.minecraft.structure.StructureSet.REGISTRY_CODEC` * `net.minecraft.structure.pool.StructurePool.REGISTRY_CODEC` * `net.minecraft.structure.processor.StructureProcessorType.REGISTRY_CODEC` * `net.minecraft.world.biome.Biome.REGISTRY_CODEC` * `net.minecraft.world.dimension.DimensionType.REGISTRY_CODEC` * `net.minecraft.world.gen.carver.ConfiguredCarver.REGISTRY_CODEC` *...

`delta`/`tickDelta`/`partialTicks` inconsistency

1

There are three names for the same thing in yarn.

The constructor parameters and the fields in `RandomOffsetPlacementModifier` are inconsistent.

1

The fields are named `spreadXz` and `spreadY`, but the constructor parameters are named `xySpread` and `ySpread`. https://github.com/FabricMC/yarn/blob/29f3c7a07edca6483012bdc10c1a638519db7b57/mappings/net/minecraft/world/gen/decorator/RandomOffsetPlacementModifier.mapping#L3-L7

`ParticleParameters` got renamed to `ParticleEffect` in #619. However, some current mappings don't respect this rename. Some search results in Minecraft source * The search result with keyword `ParticleEffect parameters`: ```...

SaplingGenerator is misleading

4

It does not generate a sapling. It generates a tree when a sapling grows naturally or when a bone meal item is used on a sapling.

Clarification on `UPPER_SNAKE_CASE` convention

3

Currently, [CONVENTIONS.md](https://github.com/FabricMC/yarn/blob/1391c4cb97080a43da516c8f82be992aab489f8d/CONVENTIONS.md) says: > Use `lowerCamelCase` for method names, variable names, and names of fields that are not both static and final. Use `UPPER_SNAKE_CASE` for names of fields that are...