yarn icon indicating copy to clipboard operation
yarn copied to clipboard

Published 20 hours ago • verified publisher icon FabricMC

The constructor parameters and the fields in `RandomOffsetPlacementModifier` are inconsistent.

Open enbrain opened this issue 3 years ago • 1 comments

The fields are named spreadXz and spreadY, but the constructor parameters are named xySpread and ySpread.

https://github.com/FabricMC/yarn/blob/29f3c7a07edca6483012bdc10c1a638519db7b57/mappings/net/minecraft/world/gen/decorator/RandomOffsetPlacementModifier.mapping#L3-L7

enbrain avatar Dec 13 '21 01:12 enbrain

It could be renamed to use horizontal/vertical as it seems to be more common in yarn although the string literals call them xz/y.

enbrain avatar Dec 13 '21 01:12 enbrain