enbrain

Results 9 comments of enbrain

I'd prefer shorter names for builder methods especially when they have high traffic. I'm not sure if consistency is that important in this context.

It could be renamed to use `horizontal`/`vertical` as it seems to be more common in yarn although the string literals call them `xz`/`y`.

> `SaplingBehavior` maybe? does it sound like pistons too much? I think sapling behavior is `SaplingBlock` itself. `PistonBehavior` might be an inaccurate name as well. Maybe `SaplingGrowthBehavior` or `TreeGrowthBehavior`?

I think a word "burn" can mean both spread fire and destroy flammable. I suggest renaming (`burnChance`, `spreadChance`) to (`spreadChance`, `destroyChance`).

This is impactful since `FlammableBlockRegistry` ([impl](https://github.com/FabricMC/fabric/blob/eb6d3039877d3d903fcaf7eca1827925e19c2a9c/fabric-content-registries-v0/src/main/java/net/fabricmc/fabric/mixin/content/registry/MixinFireBlock.java#L54-L80)) in Fabric API uses the same names as Yarn.

That sentence does not add useful information to be honest. It's repeating the method name.

Are these checks in the scope of this PR? * check for synthetic entries with javadoc * check for unnamed methods without params or javadoc * check for empty COMMENT...

I will redo this PR.