yarn icon indicating copy to clipboard operation
yarn copied to clipboard

SaplingGenerator is misleading

Open enbrain opened this issue 3 years ago • 4 comments

It does not generate a sapling. It generates a tree when a sapling grows naturally or when a bone meal item is used on a sapling.

enbrain avatar Nov 22 '21 14:11 enbrain

True, but it also does not generate a tree (you'd modify a configure feature for that.) SaplingBehavior maybe? does it sound like pistons too much?

apple502j avatar Nov 22 '21 15:11 apple502j

SaplingBehavior maybe? does it sound like pistons too much?

I think sapling behavior is SaplingBlock itself. PistonBehavior might be an inaccurate name as well.

Maybe SaplingGrowthBehavior or TreeGrowthBehavior?

enbrain avatar Nov 23 '21 12:11 enbrain

Okay, I completely forgot PistonBehavior was just an enum :P

apple502j avatar Nov 23 '21 14:11 apple502j

There is also CauldronBehavior, which is an interface.

haykam821 avatar Nov 23 '21 14:11 haykam821