Etienne Millon

Results 332 comments of Etienne Millon

Hi! suggestion from Slack: > minor suggestion regarding wording: at the moment both active jobs and completed jobs say "Ran for %dm%ds". How about using "Running for..." for active jobs?...

I replied over there to clarify the scope of the issue.

@patricoferris I'm writing this section by section, so I was wondering if it made sense to merge that section by section instead of once it's "done". how do you prefer...

I have a version ready with the main section and the one about the build system. I think it'll be better to merge this first, because there's a slight issue...

Hi, Great, I don't have an OSX system so I did not know what was the macro to use. If you submit a pull request making sure that it builds...

@yallop IIRC OSX support for Travis makes really long builds, I don't think it's worth having it permanently enabled.

N.B. there might be similar code paths with: - `CKO_CS_UNKNOWN` - `CKM_CS_UNKNOWN` - `CKR_CS_UNKNOWN` - `CKU_CS_UNKNOWN`

I'm also opening this as an interest check. This pattern can be found in many other places, as found by this ~custom static analysis tool~ perl one-liner: 36 occurences ```...

> In this context, I think that we should indeed fix the runtime to avoid it, and I would welcome a patch to do so. Thanks. 2 questions regarding that:...

Ok, I'll take back the suggestion to fix all these hits then. For this particular one (`mkdir`), I was able to see a TSAN warning about it.