Etienne Millon

Results 332 comments of Etienne Millon

Sure! But it's probably not very useful if I comment on the implementation. Do you have a description of the problem you're solving and what the approach looks like?

OK, thanks for the explanation. I think that it's a great problem to solve, that has been there with ocamlformat since I've known about it. Thanks for working on that....

good point, we forgot to add one in the PR.

(this could also be solved by keeping the proxy and adding a HTTP cache on ocaml.org's side, but this doesn't seem like the end solution)

Thanks. It's good that you managed to use the existing process code to do this. In terms of design, the most important thing to address is whether we can implement...

Let me clarify a bit what I mean: - the first thing to do is to add tests for this. this way, we can discuss concretely about how the messages...

> I'm not sure to fully understand the point here. In the PR you linked, it seems that it's using `string option` not `Context.t`. that's to avoid dependency cycles, this...

> real build instructions write to files and all output to stdout is a side-effect Let me clarify what I meant; there are some packages where `configure` outputs things like...

Ultimately, you'll be maintaining those tests, so if you're more comfortable with that approach, that's fine by me.