Etienne Millon

Results 332 comments of Etienne Millon

the spec says rsync could one day use this, but it doesn't seem that it has ever been implemented.

I'm not opposed to that feature if there's actual demand for it and it fixes a use case, but at the moment it looks like the spec is only implemented...

@ElectreAAS this is now ready, the individual commits should make sense for review.

Thanks. I can't give a full review at the moment but here are a few remarks in the meantime: - In terms of design, I don't think that this should...

Actually I'm wondering if we should make `format` per-command so that your PR could be expressed as just `--format=lines`. (also, you'll need to sign-off your contribution as described in https://github.com/ocaml/dune/blob/main/CONTRIBUTING.md)

it's interesting because the bug does not trigger with just "mkdir node_modules/@x/y; touch node_module/@x/y/z.txt"

Yes, I managed to repro with `npm` too. > stat reports entries in path are regular dirs and files. To clarify, hardlinks are regular files; did you check the link...

FTR, #9873 points to the same commit, but it's a bit different, it's when a symlink points to a dir.

one thing I haven't checked is if the issue happens when no directory starts with `@`. maybe that part is just a red herring?