Etienne Millon

Results 332 comments of Etienne Millon

@gridbugs do you know how to update the benchmarks to run on 4.14.2?

Thanks. Everything's green now so I'm merging.

Hi! I confirmed the problem; also this is not a regression (happens in 3.7.0 too). From a quick glance, this might be related to using `(modules)`. Normally you don't need...

I think `(mode promote)` is working as intended here: it's specifically about propagating promotions to the target automatically. If you want the extra check, you can use the 2-step generate...

I'm a bit surprised to see menhir pop up here because it should have been fixed in #8949. I'll try to repro, thanks.

Adding automatic aliases seems a bit too much, but my suggestion from elsewhere was to add `(alias)` and `(runtest_alias)` support to the test stanza.

@Leonidas-from-XIV 's suggestion is a good one I think but the current situation of the PR already improves the situation so I'm rebasing and merging this PR. @Leonidas-from-XIV, feel free...

Link an extra module that does `Printexc.record_backtrace true`? That's a bit overreaching maybe.

Curious to hear your thoughts about this @ElectreAAS

The piece of logs in particular was: ![image](https://user-images.githubusercontent.com/496345/202660015-6b7e4a53-5516-437c-8cf7-1a77d9b9a2c3.png) According to [contrastchecker](https://webaim.org/resources/contrastchecker/) this is contrast 1.88:1 whereas 4.5:1 is recommended for normal text.