pkcs11 icon indicating copy to clipboard operation
pkcs11 copied to clipboard

Published 20 hours ago • verified publisher icon cryptosense

Fix OSX build

Open emillon opened this issue 9 years ago • 4 comments

At the moment the build fails on osx.

Make it possible to either:

  • not build the reverse bindings (the only part that fails)
  • build the reverse bindings on osx.

The current solution (disable the whole package on osx) also works. To anyone interested: patches welcome :)

emillon avatar Oct 19 '16 07:10 emillon

The dlfcn.h header is available on osx. It seems enough (at least, it fixes the build) to generalize the #if defined(__linux__) || (defined(__sun) && defined(__SVR4)) conditional to include defined(__APPLE__).

vbgl avatar Mar 30 '17 05:03 vbgl

Hi,

Great, I don't have an OSX system so I did not know what was the macro to use.

If you submit a pull request making sure that it builds and the tests pass, I'll include that in the next release.

Thanks!

emillon avatar Mar 30 '17 07:03 emillon

It could be useful to add an OS X entry to the Travis configuration to ensure that the build keeps working.

yallop avatar Mar 30 '17 07:03 yallop

@yallop IIRC OSX support for Travis makes really long builds, I don't think it's worth having it permanently enabled.

emillon avatar Mar 30 '17 07:03 emillon