Emilia Hane
Emilia Hane
superseded by https://github.com/paradigmxyz/reth/issues/13951
I would say the codebase is ripe for his pr now. @tcoratger do you have capacity to pick it up again?
@gakonst what is it that you think is missing from the existing docs? https://github.com/paradigmxyz/reth/blob/b5926073945a18012fbdc1863f04042b56de7233/crates/rpc/rpc-eth-api/src/helpers/mod.rs#L1-L15 or do you just mean to duplicate them in the book?
can this be closed in favour of https://github.com/paradigmxyz/reth/pull/10286 @fgimenez ?
is this issue up to date?
new `reth-network-primitves` crate instead? for the standalone types
what's the argument from having a different pattern than `reth-rpc-eth-api` and `reth-rpc-eth-types` here?
> I like the block trait a lot and would focus on only this in this pr. > > implementation and changes should happen separately, because we can't introduce two...
> I'd like to do more incremental changes and only do all of this in as small chunks as possible. > > adding trait support to our block type is...
Ref https://github.com/ethpandaops/optimism-package/issues/186