Emilia Hane
Emilia Hane
looking into this. requires moving some more utility compat functions to `TransactionCompat` trait.
making `FullEthApiTypes` stateful solves this
pushing some code to your branch, overwrites all your code except for the part getting the deposit receipt version from the chain spec, to include your commits :)
This problem will appear for all `eth` methods that return the RPC transaction for op-reth. The PR fixes this for specifically for the `eth_TransactionByHash` method. In order to fix this...
> > This problem will appear for all `eth` methods that return the RPC transaction for op-reth. The PR fixes this for specifically for the `eth_TransactionByHash` method. > > In...
will solve these issues https://github.com/paradigmxyz/reth/issues/8303, especially https://github.com/paradigmxyz/reth/issues/8746 and https://github.com/paradigmxyz/reth/issues/8745
https://github.com/paradigmxyz/reth/issues/8745 and https://github.com/paradigmxyz/reth/issues/8746 should solve https://github.com/paradigmxyz/reth/issues/7322
> Or are you suggesting removing all bounds from `EthPoolTransaction` in favour of requiring `Into`/`From` on methods only where required? this :)
@mattsse tried to move away from those `Into`/`From` trait bounds recently, so don't think we want to reintroduce them now imo worth exploring if it's possible to delay those trait...
> one q, what's the meaning of AT? Thanks @emhane @mattsse Associated type https://doc.rust-lang.org/rust-by-example/generics/assoc_items/types.html. nice that you ask :)