Emilia Hane
Emilia Hane
wondering if it's tackling the problem at head better, to replace this with a `VecDeque` instead @mattsse https://github.com/paradigmxyz/reth/blob/081796b138fd00a6d0af2ad463123fdbe04765ab/crates/consensus/beacon/src/engine/mod.rs#L187-L188
doesn't work though :/ @shekhirin @mattsse and not sure why, that loop is very complex
think we should rewrite this future implementation to be a stream, so we can better reason about it. rn it's very complex to create a mental model of how this...
closing in favour of https://github.com/paradigmxyz/reth/pull/8315
you could try https://github.com/paradigmxyz/reth/issues/7500#issuecomment-2074698780 @tofanovskiy
we don't have the op-reth base datadir available for download atm @gakonst @clabby
second look at this, I see you are missing the `--enable-discv5-discovery` flag from the `op-reth` command. this is enabled by default for op stack in upcoming release https://github.com/paradigmxyz/reth/pull/8065.
> If I understood this correctly, then this refactors how the core eth-wire types `EthStream` and P2PStream work. > > most importantly the `P2PStream` will do the multiplexing over channels...
> sorry this took so long 🙈 > > I think I kinda understand how this works. > > One concern is that, if I understood this correctly, is that...
closed in favour of simplification https://github.com/paradigmxyz/reth/pull/5577