Joakim Plate

For example: https://pypi.org/project/python-magic/

Why cant we just trust the servers content type, if it report some binary format we use magic?

Its not our job to make sure servers are configured properly. We should push fixes to where they are supposed to be. Do you have a example of a server...

Ill hold off somewhat to see if @timmo001 has some comments. Ping in a week or so if we have not heard anything.

Heh. Not the way intended. But works too. I meant like: https://github.com/home-assistant/core/blob/559e28143147b85a606ef76e409b14a04c6bef3f/homeassistant/components/nibe_heatpump/__init__.py#L224 https://github.com/home-assistant/core/blob/559e28143147b85a606ef76e409b14a04c6bef3f/homeassistant/components/nibe_heatpump/__init__.py#L265

Can you rebase for the conflicts.

There are some outstanding review issues to solve first.

Adjust to data update coordinator, or at least fix the issue with terminating the client in the wrong place. Now you also need fix CLA issue from the last push.

I think you got the description mostly correct. async_unload_entry will be called of you ask to reload or disable a config entry. It should first ask all platforms (cover, switch,...

Please stop spamming me with your commit messages. Every commit with my handle in it leads to a mail.