core
core copied to clipboard
Add optional support for users with multiple ovo accounts
Proposed change
This change adds support for specifying the OVO account id during component setup. This resolves issues for users who have multiple OVO accounts as the current code selects the first account and does not allow this to be overridden. This issue was reported in https://github.com/home-assistant/core/issues/73375
Type of change
- [ ] Dependency upgrade
- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New integration (thank you!)
- [x] New feature (which adds functionality to an existing integration)
- [ ] Deprecation (breaking change to happen in the future)
- [ ] Breaking change (fix/feature causing existing functionality to break)
- [ ] Code quality improvements to existing code or addition of tests
Additional information
- This PR is related to issue: https://github.com/home-assistant/core/issues/73375
Checklist
- [x] The code change is tested and works locally.
- [x] Local tests pass. Your PR cannot be merged unless tests pass
- [x] There is no commented out code in this PR.
- [x] I have followed the [development checklist][dev-checklist]
- [ ] The code has been formatted using Black (
black --fast homeassistant tests
) - [ ] Tests have been added to verify that the new code works.
Unsure how Black works? Existing tests cover the changes from what I can see.
If user exposed functionality or configuration variables are added/changed:
- [ ] Documentation added/updated for [www.home-assistant.io][docs-repository]
I'm new to this so happy to update docs if someone can guide me
If the code communicates with devices, web services, or third-party tools:
- [ ] The [manifest file][manifest-docs] has all fields filled out correctly.
Updated and included derived files by running:python3 -m script.hassfest
. - [ ] New or updated dependencies have been added to
requirements_all.txt
.
Updated by runningpython3 -m script.gen_requirements_all
. - [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
- [ ] Untested files have been added to
.coveragerc
.
To help with the load of incoming pull requests:
- [ ] I have reviewed two other open pull requests in this repository.
Being so new I would not be confident reviewing PRs at the moment
Hi gingemonster
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
Hey there @timmo001, mind taking a look at this pull request as it has been labeled with an integration (ovo_energy
) you are listed as a code owner for? Thanks!
Code owner commands
Code owners of ovo_energy
can trigger bot actions by commenting:
-
@home-assistant close
Closes the issue. -
@home-assistant rename Awesome new title
Change the title of the issue. -
@home-assistant unassign ovo_energy
Removes the current integration label and assignees on the issue, add the integration domain after the command.
I believe these latest changes cover what you have requested
Ill hold off somewhat to see if @timmo001 has some comments. Ping in a week or so if we have not heard anything.