Raise exception when esphome ble client disconnects during operation

[bdraco]

Proposed change

Raise exception when esphome ble client disconnects during operation

Currently we wait for the timeout which means we don't get retries because we don't know that the ble client disconnected out from under us which all the other bleak clients do.

Type of change

• [ ] Dependency upgrade
• [x] Bugfix (non-breaking change which fixes an issue)
• [ ] New integration (thank you!)
• [ ] New feature (which adds functionality to an existing integration)
• [ ] Deprecation (breaking change to happen in the future)
• [ ] Breaking change (fix/feature causing existing functionality to break)
• [ ] Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue:
• Link to documentation pull request:

Checklist

• [x] The code change is tested and works locally.
• [ ] Local tests pass. Your PR cannot be merged unless tests pass
• [ ] There is no commented out code in this PR.
• [ ] I have followed the development checklist
• [ ] The code has been formatted using Black (black --fast homeassistant tests)
• [ ] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• [ ] Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• [ ] The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• [ ] New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
• [ ] Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

• [ ] I have reviewed two other open pull requests in this repository.

[home-assistant[bot]]

Hey there @ottowinter, @jesserockz, mind taking a look at this pull request as it has been labeled with an integration (esphome) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of esphome can trigger bot actions by commenting:

• @home-assistant close Closes the issue.
• @home-assistant rename Awesome new title Change the title of the issue.
• @home-assistant unassign esphome Removes the current integration label and assignees on the issue, add the integration domain after the command.

[bdraco]

We could cancel the running task instead. Feel like it could be cleaner. I do that in the nibe_heatpump coordinator on unload. Just remember active task on function entry, and cancel any running tasks on disconnect event.

I'll adjust it to cancel the task if it works out ok in testing

[bdraco]

It will cancel the task, but still raise BleakError to ensure anything looking for BleakError and retrying will still retry to make sure its compatible with existing libraries

[bdraco]

Thanks!

[elupus]

Heh. Not the way intended. But works too.

I meant like: https://github.com/home-assistant/core/blob/559e28143147b85a606ef76e409b14a04c6bef3f/homeassistant/components/nibe_heatpump/init.py#L224 https://github.com/home-assistant/core/blob/559e28143147b85a606ef76e409b14a04c6bef3f/homeassistant/components/nibe_heatpump/init.py#L265