core icon indicating copy to clipboard operation
core copied to clipboard

Add Remootio integration

Open ivgg-me opened this issue 3 years ago • 31 comments

Proposed change

This change adds an integration for Remootio to Home Assistant.

Type of change

  • [ ] Dependency upgrade
  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [x] New integration (thank you!)
  • [ ] New feature (which adds functionality to an existing integration)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [ ] Code quality improvements to existing code or addition of tests

Additional information

The integration is compatible with Remootio devices with a software version >= v2.21 which have a sensor installed.

  • PR for logos and icons: home-assistant/brands#3035
  • PR for documentation: home-assistant/home-assistant.io#20970

Checklist

  • [x] The code change is tested and works locally.
  • [x] Local tests pass. Your PR cannot be merged unless tests pass
  • [x] There is no commented out code in this PR.
  • [x] I have followed the development checklist
  • [ ] The code has been formatted using Black (black --fast homeassistant tests)
  • [x] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [x] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [x] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • [ ] Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • [x] No score or internal
  • [ ] 🥈 Silver
  • [ ] 🥇 Gold
  • [ ] 🏆 Platinum

To help with the load of incoming pull requests:

ivgg-me avatar Dec 31 '21 21:12 ivgg-me

Hi @ivgg-me,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

homeassistant avatar Dec 31 '21 21:12 homeassistant

HI @ivgg-me will you be able to provide a dummies guide on how to setup the remootio in Home-Assistant? I'm a NOO with no clue on how to get it working. thanks a million!!!!!

McAllstar avatar Jan 14 '22 09:01 McAllstar

HI @ivgg-me will you be able to provide a dummies guide on how to setup the remootio in Home-Assistant? I'm a NOO with no clue on how to get it working. thanks a million!!!!!

Do you mean with this integration or without? - This integration is not yet included in Home Assistant, it awaits currently a review and I hope it will be included in a future version of Home Assistant.

ivgg-me avatar Jan 14 '22 21:01 ivgg-me

hopefully this can be added soon as also looking forward to its integration

sam43434 avatar Jan 27 '22 14:01 sam43434

Hey @elupus we are eagerly awaiting the approval on the remootio integration for HA. hopefully it gets approval soon soon soon. nadge nudge wink wink!!!

McAllstar avatar Feb 02 '22 06:02 McAllstar

Hey @elupus we are eagerly awaiting the approval on the remootio integration for HA. hopefully it gets approval soon soon soon. nadge nudge wink wink!!!

whats taking so long to get this approved and integrated into HA?

McAllstar avatar Mar 08 '22 18:03 McAllstar

Can you rebase for the conflicts.

elupus avatar Mar 08 '22 21:03 elupus

@elupus Can you please review my last changes. It would be nice that this integration will be included in the next version of Home Assistant. Thank you!

ivgg-me avatar Apr 09 '22 08:04 ivgg-me

Thanks for everyone's efforts! Will this make it into the May release?

woopsicle avatar Apr 21 '22 23:04 woopsicle

There are some outstanding review issues to solve first.

elupus avatar Apr 22 '22 07:04 elupus

Has work on this gone stale @ivgg-me ?

DanielNagy avatar Jun 02 '22 23:06 DanielNagy

hope not, we seems so close

McAllstar avatar Jun 03 '22 05:06 McAllstar

hope not, we seems so close

Agree.. So much good work has already been done by @ivgg-me. Looks like very little now to get it across the line :D

DanielNagy avatar Jun 03 '22 05:06 DanielNagy

hope not, we seems so close

Agree.. So much good work has already been done by @ivgg-me. Looks like very little now to get it across the line :D

I'm working on it. I will push some changes in the next days and hope then this request will be accepted and it can be merged into the core.

ivgg-me avatar Jun 03 '22 21:06 ivgg-me

There are some outstanding review issues to solve first.

@elupus: Can you please review this request again. Thank you!

ivgg-me avatar Jun 07 '22 20:06 ivgg-me

Wondering whether there is any update here, @elupus. Would be grateful for a successful integration! (And thank you, Joakim, for all your hard work.)

jamesbeldock avatar Jul 04 '22 02:07 jamesbeldock

@jamesbeldock I do understand you want help moving things forward, but please don't ping people for reviews. It can come across demanding (even if that is not the intention). So, please don't do that. Thanks for understand and being patient 👍

frenck avatar Jul 04 '22 07:07 frenck

Hello @ivgg-me,

When attempting to inspect the commits of your pull request for CLA signature status among all authors we encountered commit(s) which were not linked to a GitHub account, thus not allowing us to determine their status(es).

The commits that are missing a linked GitHub account are the following:

Unfortunately, we are unable to accept this pull request until this situation is corrected.

Here are your options:

  1. If you had an email address set for the commit that simply wasn't linked to your GitHub account you can link that email now and it will retroactively apply to your commits. The simplest way to do this is to click the link to one of the above commits and look for a blue question mark in a blue circle in the top left. Hovering over that bubble will show you what email address you used. Clicking on that button will take you to your email address settings on GitHub. Just add the email address on that page and you're all set. GitHub has more information about this option in their help center.

  2. If you didn't use an email address at all, it was an invalid email, or it's one you can't link to your GitHub, you will need to change the authorship information of the commit and your global Git settings so this doesn't happen again going forward. GitHub provides some great instructions on how to change your authorship information in their help center.

    • If you only made a single commit you should be able to run
      git commit --amend --author="Author Name <[email protected]>"
      
      (substituting Author Name and [email protected] for your actual information) to set the authorship information.
    • If you made more than one commit and the commit with the missing authorship information is not the most recent one you have two options:
      1. You can re-create all commits missing authorship information. This is going to be the easiest solution for developers that aren't extremely confident in their Git and command line skills.
      2. You can use this script that GitHub provides to rewrite history. Please note: this should be used only if you are very confident in your abilities and understand its impacts.
    • Whichever method you choose, I will come by to re-check the pull request once you push the fixes to this branch.

We apologize for this inconvenience, especially since it usually bites new contributors to Home Assistant. We hope you understand the need for us to protect ourselves and the great community we all have built legally. The best thing to come out of this is that you only need to fix this once and it benefits the entire Home Assistant and GitHub community.

Thanks, I look forward to checking this PR again soon! :heart:

homeassistant avatar Jul 17 '22 12:07 homeassistant

Hi @GitHub-Action,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

homeassistant avatar Jul 17 '22 16:07 homeassistant

What else do I have to do to get this MR approved?

ivgg-me avatar Jul 17 '22 16:07 ivgg-me

Adjust to data update coordinator, or at least fix the issue with terminating the client in the wrong place. Now you also need fix CLA issue from the last push.

elupus avatar Jul 17 '22 16:07 elupus

Adjust to data update coordinator, or at least fix the issue with terminating the client in the wrong place. Now you also need fix CLA issue from the last push.

@elupus : Can you please answer my question from June 12 so I understand how the workflow in HASS is? This would then also make the need for the adjustment you want clearer to me. Thank you!

ivgg-me avatar Jul 24 '22 09:07 ivgg-me

Adjust to data update coordinator, or at least fix the issue with terminating the client in the wrong place. Now you also need fix CLA issue from the last push.

@elupus : Can you please answer my question from June 12 so I understand how the workflow in HASS is? This would then also make the need for the adjustment you want clearer to me. Thank you!

@elupus: Please!

ivgg-me avatar Sep 25 '22 09:09 ivgg-me

I think you got the description mostly correct.

async_unload_entry will be called of you ask to reload or disable a config entry. It should first ask all platforms (cover, switch, ...) to unload (which will remove all entites, calling the will remove callback on all entities registered on that config entry and platform). Once that is complete, the integration async_unload_entry will (should) continue to disconnect any connections and remnant state of the integration.

It should be done in this order to avoid any entities being dependent on unloaded global state/connections.

elupus avatar Sep 25 '22 09:09 elupus

Hi zlodag

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

home-assistant[bot] avatar Oct 27 '22 15:10 home-assistant[bot]

@elupus : Can you please review and approve this MR. I think the integration is now suitable to be part of HASS. Thank you!

ivgg-me avatar Oct 27 '22 21:10 ivgg-me

Hi zlodag

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

home-assistant[bot] avatar Oct 27 '22 21:10 home-assistant[bot]

@ivgg-me Maybe just squash those commits so it's not blocked on the CLA?

osterman avatar Oct 29 '22 14:10 osterman

Please stop spamming me with your commit messages. Every commit with my handle in it leads to a mail.

elupus avatar Nov 01 '22 18:11 elupus