Eli Bendersky comments

Results 225 comments of


                                            Eli Bendersky

Adding printouts to make code easier to correlate to output

Yes, but on a case-by-case basis for specific examples

Add examples for `errgroup`

While there's some preference to stdlib-only, I'm not completely opposed to examples of `errgroup`. Suggestions welcome (PR is a good format for that)

Add implementation of "buffer_window" and "redisChatMessage History"

This PR seems to be adding a lot of new code without explaining what the code is for and what problem it's trying to solve. You've also ignored the PR...

CGenerator doesn't consider the NOT operator when using reduce_parentheses=True

PRs to fix this are welcome

TypeDecl nodes of _Atomic C11 declarations have empty coord

PRs welcome

TypeError: 'NoneType' object is not iterable in visit_case function of c_generator.py

Thanks for the report. Feel free to send a PR with a fix + test

_Atomic support broken

Please do not post screenshots of code or output. Paste a minimal yet complete reproducer instead.

offsetof parsing fails due to TYPEID as offsetof_member_designator

Thanks for the detailed report. To help further narrow down the issue you can insert a printout (or a stack trace) where `CParser` adds `object` to the type map (from...

AttributeError: 'Coord' object has no attribute 'type'

Please provide a minimal, reproducible example: https://stackoverflow.com/help/minimal-reproducible-example And don't forget to properly format the issue report

Pragmas in enum declaration raise error

Yep, pragmas aren't supported within enums now. PRs welcome