Eli Bendersky comments

Results 225 comments of


                                            Eli Bendersky

Error executing code due to file path on windows

Can you open a PR?

vertexai(test): add corpora_test in tokenizer module

For the failing checks: 1. vet - you can run it from the `.github/workflows` directory locally on your machine to weed out all the failures before sending an updated PR...

Document relationship with cloud SDK genai client

Thanks for the note. We're thinking about the topic of documentation more holistically now across the different SDKs and languages; I will keep this issue open for now

Incorrect Parsing of Hexadecimal Floating Point Literals

Thank you for the report. Please feel free to submit a PR with a fix

llms: Add fake package

You checked " Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. Fixes #123).", but in fact it's...

Incorrect removal of parentheses after the comma operator followed by a compound statement

PRs to fix this are welcome. Please note that the ability to generate C code back from the AST is not considered a critical capability of pycparser; while I'll accept...

Constant string concatenation

I don't understand the issue. The following C program prints `abcxyz`, according to the standard: ```c #include int main() { char* str = "abc""xyz"; printf("%s\n", str); return 0; } ```...

Constant string concatenation

Ah, so it's specific to octal and hex, then... PR to fix welcome, though it has to handle all cases of string literal concatenation properly

patch: fix NoneType error for 'visit_Case' function in c_generator.py…

Yes, I understand My question is - can you add a test to https://github.com/eliben/pycparser/blob/main/tests/test_c_generator.py as part of your PR that triggers this behavior and verifies that the change fixes it

Check for SHN_UNDEF during symbol dumping

I like the change more but agree that the motivation remains mysterious, especially without any test case. Is this similar to what `readelf` itself is doing in a comparable code...