Eli Bendersky
Eli Bendersky
@Omid-SH consider submitting a PR with a *simple* example to this repository. That will be easier to review.
I'm actually working on porting Construct to Python 3 (same-codebase support for both 2 & 3), in my fork here - https://github.com/eliben/construct. Stay tuned
I don't think we're going to accept this PR for now. Nothing wrong with the PR itself, but wire is in maintenance mode. It does what we need it to...
Thanks for the suggestion @phroggyy I'll keep this issue open as a feature request, but we consider wire feature-complete at this point and will not be adding features. We want...
The underlying reason here seems to be a difference in behavior between the go tool and gopackages. With the go tool, when there is no empty line between the build...
It occurred to me that wire doesn't even try to find files with the `wireinject` build constraint. It looks through all the files in the package *that don't have the...
After chatting about this with @light - one thing we could do is check that files where we find injector calls have the proper build constraints set and complain if...
See for example this code: https://github.com/eliben/pykaleidoscope/blob/master/chapter7.py#L604 The idea is: at some point I want to add stuff to the beginning of the entry block (allocas are one common case). The...
Ah yes, indeed those look relevant & interesting.
Thanks. Could you create a PR for this? Please try to add a test that demonstrates the failures that are fixed by the change.