Eli Bendersky

Results 225 comments of Eli Bendersky

> > Let me explain what happened: When calling `llm` via `chain`, because it goes through the function: > > https://github.com/tmc/langchaingo/blob/853fc0492d2331518252a357759546abfb1f9fea/chains/options.go#L132-L158 > This doesn't seem right to me, because it...

@FluffyKebab @tmc why do we have `chains/options.go` which duplicates most things in `llms/options.go`? A serious problem with this approach is that `getLLMCallOptions` in `chains/options.go` hard-sets all the options on the...

@Abirdcfly thanks for finding these. PTAL at #632 which is a backwards-compatible fix that makes sure to only override call options when they were explicitly set on chain options. I...

This isn't done yet. We want to reconsider the duplication of options in chains

@Henri-J-Norden do you have small reproducers that demonstrate this? The ideal would be a simple C file we could compile and observe this on (using pyelftools)

Setting `SystemInstruction` should work now, you can see an example at https://pkg.go.dev/github.com/google/generative-ai-go/genai#example-GenerativeModel.GenerateContent-Config Note that you need a Gemini 1.5 model for that, since 1.0 doesn't support system instructions. Set the...

#92 fixes the example to use an appropriate model. > Is it possible to learn if 1.0 will ever get system instructions? Unfortunately, we don't know.

> There is the one in `/api`, which is what we use for the REPL, but it's not as well commented as the python/js client libraries. Thanks for your reply...

SGTM, I'll look into it