langchaingo icon indicating copy to clipboard operation
langchaingo copied to clipboard

Add implementation of "buffer_window" and "redisChatMessage History"

Open MAlj11 opened this issue 2 years ago • 2 comments

PR Checklist

  • [x] Read the Contributing documentation.
  • [ ] Read the Code of conduct documentation.
  • [ ] Name your Pull Request title clearly, concisely, and prefixed with the name of the primarily affected package you changed according to Good commit messages (such as memory: add interfaces for X, Y or util: add whizzbang helpers).
  • [ ] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • [ ] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. Fixes #123).
  • [ ] Describes the source of new concepts.
  • [ ] References existing implementations as appropriate.
  • [ ] Contains test coverage for new functions.
  • [ ] Passes all golangci-lint checks.

MAlj11 avatar Nov 30 '23 12:11 MAlj11

Can you please merge my commits into the main branch?

MAlj11 avatar Dec 04 '23 06:12 MAlj11

This PR seems to be adding a lot of new code without explaining what the code is for and what problem it's trying to solve.

You've also ignored the PR creation checklist which - among other things - asks you to provide such an explanation.

Can you start with an issue that explains what is missing and how you propose to fix it?

eliben avatar Dec 04 '23 13:12 eliben