Eli Bendersky
Eli Bendersky
@zhangyunhao116 I'm not a big fan of this proposal at this time. The problem with sorting floats is clearly documented and a workaround is provided. It's easy to sort using...
Thanks, this looks interesting. Please let me know when you think this PR is ready for review.
Just a quick note that I don't plan to review/merge this any time soon. This is a rather complicated change, and I don't have the capacity to review it now....
Thanks for the attempt. I'm not 100% sure it fits the general flow of gobyexample, being so synthetic. Have to think more about this
> Yes. IMO it's fine to have code duplicated in the modules of each samples. > > Factoring would imply putting image+video in the same sample folder, which is fine...
> In this page we want to show a distinct snippet in the two section "Image" and "Video" > > https://cloud.google.com/vertex-ai/docs/generative-ai/multimodal/send-multimodal-prompts#gemini-send-multimodal-samples-go OK, fair enough, then please make it as identical...
> I'm getting compile errors at `example_test.go`, @jba can you PTAL? Is it a vet error? What does it say?
Thanks @apshoemaker ! I'm going to close this issue for now. @galeone please reopen if you still see it on the latest release. If you do, please provide a minimal,...
Thanks, @aherlihy I'll have to think a bit whether I want this in the Makefile, or just to point folks to this pull request if they ask about Darwin.