js-8080-sim icon indicating copy to clipboard operation
js-8080-sim copied to clipboard

Support basic current line highlighting

Open wizche opened this issue 3 years ago • 4 comments

This repo was exactly what I was looking for to get some quick hands-on with 8080 processor while reading the awesome book "Code: The Hidden Language of Computer Hardware and Software, 2nd Edition". Thanks a lot!

I started to implement highlighting of executed instruction, would also be nice to extend this to highlight changes in the register and memory view.

It seems to work, the only issue I could find is when "entering" on an highlighted line the caret positioning is messed up...

sim

wizche avatar Oct 17 '22 16:10 wizche

Thanks, this looks interesting. Please let me know when you think this PR is ready for review.

eliben avatar Oct 19 '22 13:10 eliben

I guess we can live with the issue when entering on the highlighted line... I would rather submit the highlight changes in registers and memory feature on a different PR.

wizche avatar Dec 12 '22 13:12 wizche

I somehow fixed the enter issue, far from perfect though...

wizche avatar Dec 13 '22 08:12 wizche

Just a quick note that I don't plan to review/merge this any time soon. This is a rather complicated change, and I don't have the capacity to review it now. Folks interested in using this can easily apply this PR onto their clone (or check it out directly).

I may get back to this in the future

eliben avatar Dec 13 '22 18:12 eliben