Elena Frank

Are we sure that `ring::rsa::Keypair::sign` can not fail for other reasons? I know its description only mentions an error when the buffer length doesn't match, but looking into the function...

It would be great if we could do at least some of the fuzzy testing mentioned in this issue to really be sure.

> friendly ping Hi! We had quite an influx of airdrop farming, so we decided to generally just bundle together all PRs that only do small `typo-fix`es. We'll include the...

The hardcoded `_p2p._udp.local` service name is part of the libp2p specs[^1]. Still, I agree that it is a realistic use-case that multiple protocols, or even multiple nodes in the same...

Actually, all protocols in the [`protocols/`](https://github.com/libp2p/rust-libp2p/tree/master/protocols) folder implement a custom behavior, so you can use any of them as example. The simplest one is `protocols/ping`, so that might be a...

Thank you for your contribution @tesol2y090 and sorry for the delay here! Will try to give this a review in the next days.

Regarding whether `poll_close` should wait for the `FIN_ACK` or not (see https://github.com/libp2p/rust-libp2p/pull/5687#discussion_r1898455099). As already mentioned, the current implementation won't work when there are blocking calls to `close().await`, because without a...

> > Thanks @tesol2y090! > > I think we should first deprecate support for draft-29 before removing it completely, see _Step 1_ in [#3395 (comment)](https://github.com/libp2p/rust-libp2p/issues/3395#issuecomment-1701277805). > > What is the...

Seems like there is positive feedback on closing the connection in this scenario https://github.com/libp2p/specs/issues/651#issuecomment-2536663501, so I think we could follow up there with a PR that adds it to the...

> I realize that an important hint may be that my `Behaviour` is using mdns. I do not recognize the detected PeerId from the logged event, so I suspect this...