Elena Frank

Results 140 comments of Elena Frank

> I'd be more than happy to help but it's not entirely clear to me where/how framed vs non-framed is useful. I haven't done much with that transport myself, but...

Thanks for this effort @drHuangMHT! But looking through the code of this PR, I am unsure if this will really help newcomers. It's 1200 lines of code that are mostly...

> Do you think some simple macros will make it better? Well, we already have the `NetworkBehavior` macro that does everything :smile:. I don't think adding more macros in the...

> I would like to see if it is possible to negotiate protocols dynamically(instead of Toggle) and it seems it is? What do you mean with _negotiate protocols dynamically_?

Thank you for opening the issue and for the detailed description! Those are very good points. Regarding _6.2 Responding to Address Queries_: I wasn't able to find any prio discussion...

> 6.2. Responding to Address Queries Opened #6003.

Thank you for the detailed bug report and for elaborating a possible solution! Sorry for the late reply. > ### Possible Solution > > 1. Update [`Transport::Dial`](https://github.com/libp2p/rust-libp2p/blob/master/core/src/transport.rs#L137) to yield both...

> [@dmitry-markin](https://github.com/dmitry-markin) [@elenaf9](https://github.com/elenaf9) I've left a draft PR that tries to tackle this. So far it's working, but I would love to add more unit test to confirm this new...

> Thank you for letting us know. In this case, we should probably deprecate async-std completely and in the next breaking release, remove it altogether. Thoughts on this @jxs @elenaf9?...

Opened a separate issue #5935 to discuss this.