Elena Frank

Results 140 comments of Elena Frank

I went through the repo. Still missing right now are the tests in: - [ ] `multistream-select` - [x] `rw-stream-sink` (open PR: #6023) - [x] `mplex` - [x] `request-response` (open...

> Hey @elenaf9 , may I open a PR addressing the tests in `multistream-select` to use `tokio` ? @kamuik16 are you currently working on that? If not, sure @PoulavBhowmick03! Thanks.

> @elenaf9 Good day! @jxs told me you're planning to remove`async-std` feature from `quic`. If this is the case, I could do it to make 'quic' a bit simpler and...

Thank you for this great effort @jakubDoka! I know I am a bit late to the party, but @jxs and I have been talking out of band about merging this...

> Looking to integrate rust-libp2p but this is one of the prerequisites, does this need further review for merge? Sorry, I didn't have much capacity for rust-libp2p lately. Help, especially...

Could you share your `NetworkBehavior` setup? I.e. which behaviors are you using and in which order? And specifically: which two behaviors are you using in the `Either` behavior? And do...

I just noticed that the relay protocol internally uses `Either` as connection handler, and the relay protocol also seems to be used by both of you. My guess is that...

Yes. As I already suspected it was a problem in the relay network behavior, that is fixed with #5765. @joshuef please re-open if the issue persists. --- That said, I...

> rust-libp2p should call/maintain [join_multicast_v6](https://doc.rust-lang.org/std/net/struct.UdpSocket.html#method.join_multicast_v6) for each interface. It already calls `join_multicast_v6` each time a new address is discovered, however it then each time sets the `interface_index` to 0 (i.e....

Opened https://github.com/libp2p/if-watch/pull/51 to expose the information about the interface index for an address in if-watcher, will test this with mDNS in the next days.