rust-libp2p
rust-libp2p copied to clipboard
feat(quic): remove QUIC draft-29 version support
Description
Remove support support_draft_version field from QUIC protocol.
https://github.com/libp2p/rust-libp2p/issues/3395
Change checklist
- [x] I have performed a self-review of my own code
- [ ] I have made corresponding changes to the documentation
- [x] I have added tests that prove my fix is effective or that my feature works
- [ ] A changelog entry has been made in the appropriate crates
This pull request has merge conflicts. Could you please resolve them @tesol2y090? 🙏
Thanks @tesol2y090!
I think we should first deprecate support for draft-29 before removing it completely, see Step 1 in #3395 (comment).
What is the best way to deprecate support for draft-29, i thought remove the field is ok.
Thanks @tesol2y090! I think we should first deprecate support for draft-29 before removing it completely, see Step 1 in #3395 (comment).
What is the best way to deprecate support for draft-29, i thought remove the field is ok.
Rust offers the #[deprecated(note = "...")] attribute, which will give the user a warning (used e.g. in #3747).
To deprecate support of draft-29 (which is opt-in anyway), we only need to add this attribute to libp2p_quic::Config::support_draft_29.
Removing draft-29 and all related logic (what this PR is doing) can then be done in a follow-up PR after the next release of libp2p-quic.
Thanks @tesol2y090! I think we should first deprecate support for draft-29 before removing it completely, see Step 1 in #3395 (comment).
What is the best way to deprecate support for draft-29, i thought remove the field is ok.
Rust offers the
#[deprecated(note = "...")]attribute, which will give the user a warning (used e.g. in #3747).To deprecate support of
draft-29(which is opt-in anyway), we only need to add this attribute tolibp2p_quic::Config::support_draft_29.Removing draft-29 and all related logic (what this PR is doing) can then be done in a follow-up PR after the next release of
libp2p-quic.
Thank you @elenaf9 . I just created another https://github.com/libp2p/rust-libp2p/pull/5786 about deprecate support_draft_29