go-elasticsearch

go-elasticsearch copied to clipboard

Deadlock in go-elasticsearch/estransport/connection.go ？！

4

I have some golang programs using go-elasticsearch to access my ES cluster. I found that one of them can't work any more so I use the pprof by http://x.x.x.x/debug/pprof/goroutine?debug=1 to...

bjkxt

Automatically drain the body on close?

1

I just started using the module, and was a little surprised by the drain + close behavior. I completely understand the need to always require `res.Body.Close()`, and that's pretty standard...

rw-access

https://github.com/elastic/go-elasticsearch/blob/996ee1fe69ab40ad65795e48d125b6b4395b6ec3/esutil/bulk_indexer.go#L504 ``` if res.IsError() { atomic.AddUint64(&w.bi.stats.numFailed, uint64(len(w.items))) if w.bi.config.OnError != nil { w.bi.config.OnError(ctx, fmt.Errorf("flush: %s", err)) } return fmt.Errorf("flush: %s", res.String()) } ``` When you enter this if, you will...

maxbolgarin

Accessing BulkIndexerItem in OnError function

3

in esutil package,I would like to access BulkIndexerItem parameter in OnError function of BulkIndexerConfig struct instance so that I can produce dead letters when connection is gone. Will it be...

youngstone89

Hi all, I've been messing around with this library and came across that [NewBulkIngestor](https://github.com/elastic/go-elasticsearch/blob/6cdebcf1b94eb2bf022ce0689762049cb07103e0/esutil/bulk_indexer.go#L188) does not seem to return an error in any case. The only place where an error...

liamphmurphy

Proposal. There could be `nil pointer dereference` in these methods. Check if req, res and req.URL are not `nil`.

tty2

Transport: metrics.Metrics.String remove redundant index increment in the loop

1

The removed line does nothing. Index `i` is incremented by `range` clause and increment inside the range clause body doesn't affect it.

tty2

Return error when default URL cannot be parsed

3

This changes are more as a proposal. I see the point why this error check is not so important (we parse default url), but error check can help if someone...

tty2

Expose individual apis

5

I believe this is one of the major asks in https://github.com/elastic/go-elasticsearch/issues/172, the other being something like an `elasticsearch.NewTransport` function that you could pass to each of these if you so...

andrewstucki

Error while adding go-elasticsearch package

12

Please help me debug this error while importing go-elasticsearch using the commands and files mentioned in ReadMe. Error : ./../pkg/mod/github.com/elastic/go-elasticsearch/[email protected]/estransport/estransport.go:118:32: httpTransport.Clone undefined (type *http.Transport has no field or method Clone)

pallavibatra-cpi