Ewoud Kohl van Wijngaarden
Ewoud Kohl van Wijngaarden
Often the only way to know that is to run it. We usually don't have a good way to detect why something is broken.
The module has been migrated to Vox Pupuli and not seen a release yet. I'd go for a full major release that sets a new baseline.
Shouldn't this fail on https://github.com/voxpupuli/puppet-jenkins/pull/1083?
Do you run `puppet types generate` in your deployment?
Looks like this fails in the same way so my chance probably didn't cause it.
There's still a merge commit in there.
> Added a note about POSIX not windows. .. I dont have a windows machine to hand to see what it does. Me neither, but quoting https://ruby-doc.org/core-3.1.2/Etc.html > The [Etc](https://ruby-doc.org/core-3.1.2/Etc.html)...
I wouldn't expect a module to modify a vhost. Instead it deploys a mod config, which sets a default. Isn't that enough? If not, I'd think that `apache::vhost` needs a...
That would be here. https://github.com/puppetlabs/puppetlabs-apache/blob/03c507fa3d0ac3afb33cd997ffd9dd57ac035b93/manifests/mod/remoteip.pp#L73C4-L73C4 I agree it's a confusing way. Prior to 4e4bad04c8404325631a114d9c42f05924b05881 it was clearer. I don't understand why it was implemented this way.
> > That would be here. https://github.com/puppetlabs/puppetlabs-apache/blob/03c507fa3d0ac3afb33cd997ffd9dd57ac035b93/manifests/mod/remoteip.pp#L73C4-L73C4 > > I agree it's a confusing way. Prior to [4e4bad0](https://github.com/puppetlabs/puppetlabs-apache/commit/4e4bad04c8404325631a114d9c42f05924b05881) it was clearer. I don't understand why it was implemented this way....