Ewoud Kohl van Wijngaarden

It does get automatically updated, but I think few reviewers actually request changes and only submit a review

I have thought about that before and think it makes sense. It's been on my todo list for ages to write up a description of how it works. Perhaps this...

Example of where the bot is acting: https://github.com/theforeman/foreman/pull/10245#pullrequestreview-2192086820 It's important to know that there are 3 ways to submit a review: * Approved * Comment * Request changes Keeping that...

It was introduced in https://github.com/theforeman/prprocessor/commit/dcc45c7ab15be574e3b45be9d59754f6fc1978a1. There's a very good chance that was right when the feature was introduced (I still recall using GH without the reviews feature and we just...

https://community.theforeman.org/t/reviewing-prprocessors-review-labels/38844

Another thing: I just noted we have 3 places where we configure IPA enrollment: ```console $ rg ipa-client guides/common/modules/con_configuring-project-with-external-idm-dns.adoc 26:When you are using the realm enrollment feature of {Project}, where...

The reason I looked at this was that @Griffin-Sullivan was asking about the realm feature. There are also other aspects that I think are questionable. For example, sharing the keytab...

We should remove SHA1 from the application because it has no place in 2024. > BCrypt password cost: BCrypt hashing cost, higher value leads to approximately 50 milliseconds. This number...

FYI: I'm working on clear guidance on the policy for Satellite. Right now it's very inconsistent and I'd prefer to clarify that.

I share @evgeni's concerns. Today's installation may be broken, but the restore may fix that. Also, if it fails, what action does the user have?