puppetlabs-apache icon indicating copy to clipboard operation
puppetlabs-apache copied to clipboard

Feature: Allow to set the verbosity of the debug

Open JGodin-C2C opened this issue 1 year ago • 10 comments
trafficstars

Summary

Allow to set the verbosity of the debug

JGodin-C2C avatar Jan 31 '24 16:01 JGodin-C2C

The tests errors does not seems to be related to my new code.

JGodin-C2C avatar Feb 02 '24 13:02 JGodin-C2C

hello ! what is missing here to see this merged in the main branch ?

JGodin-C2C avatar Feb 27 '24 12:02 JGodin-C2C

The tests errors does not seems to be related to my new code.

Hey! This should have been fixed in the main branch.

Can you please rebase your changes on top of it?

From your working directory:

git fetch origin       # Download the latest code we have here
git rebase origin/main # Move your commits on top of the main branch
git push -f            # Send the changes (-f is required because we re-wrote history)

smortex avatar Feb 27 '24 12:02 smortex

@JGodin-C2C please take a look at your git history. you did a merge instead of a merge. Please do a proper rebase, as @smortex suggested, to remove the merge commit.

bastelfreak avatar Feb 27 '24 12:02 bastelfreak

@JGodin-C2C please take a look at your git history. you did a merge instead of a merge. Please do a proper rebase, as @smortex suggested, to remove the merge commit.

Yep, sorry, juggling with different remote is sometime hazardous.

Rebase should be correct now.

JGodin-C2C avatar Feb 27 '24 13:02 JGodin-C2C

That feels good!

Thanks for taking time to review my Merge Request even tho i stumbled on the carpet on repeated time

JGodin-C2C avatar Feb 27 '24 13:02 JGodin-C2C

Sorry :( i pushed to the main branch again. my bad.

JGodin-C2C avatar Feb 27 '24 14:02 JGodin-C2C

Hey @smortex i hope it's okay to query you in that way.

Any way to see this approved and merged ?

JGodin-C2C avatar Mar 05 '24 07:03 JGodin-C2C

There's still a merge commit in there.

ekohl avatar Apr 29 '24 16:04 ekohl

okay, so, i took the tests from this PR (kudos to @zzacharo ): https://github.com/puppetlabs/puppetlabs-apache/pull/2524 and rebased.

JGodin-C2C avatar Apr 30 '24 07:04 JGodin-C2C

Hello ! @smortex @bastelfreak en little reminder that this PR is still ongoing.

JGodin-C2C avatar Jan 09 '25 08:01 JGodin-C2C

Hi, I'm currently holding off with reviews until https://www.puppet.com/blog/open-source-puppet-updates-2025 is sorted out.

bastelfreak avatar Jan 09 '25 10:01 bastelfreak