puppetlabs-apache
puppetlabs-apache copied to clipboard
Feature: Allow to set the verbosity of the debug
Summary
Allow to set the verbosity of the debug
The tests errors does not seems to be related to my new code.
hello ! what is missing here to see this merged in the main branch ?
The tests errors does not seems to be related to my new code.
Hey! This should have been fixed in the main branch.
Can you please rebase your changes on top of it?
From your working directory:
git fetch origin # Download the latest code we have here
git rebase origin/main # Move your commits on top of the main branch
git push -f # Send the changes (-f is required because we re-wrote history)
@JGodin-C2C please take a look at your git history. you did a merge instead of a merge. Please do a proper rebase, as @smortex suggested, to remove the merge commit.
@JGodin-C2C please take a look at your git history. you did a merge instead of a merge. Please do a proper rebase, as @smortex suggested, to remove the merge commit.
Yep, sorry, juggling with different remote is sometime hazardous.
Rebase should be correct now.
That feels good!
Thanks for taking time to review my Merge Request even tho i stumbled on the carpet on repeated time
Sorry :( i pushed to the main branch again. my bad.
Hey @smortex i hope it's okay to query you in that way.
Any way to see this approved and merged ?
There's still a merge commit in there.
okay, so, i took the tests from this PR (kudos to @zzacharo ): https://github.com/puppetlabs/puppetlabs-apache/pull/2524 and rebased.
Hello ! @smortex @bastelfreak en little reminder that this PR is still ongoing.
Hi, I'm currently holding off with reviews until https://www.puppet.com/blog/open-source-puppet-updates-2025 is sorted out.