Ewoud Kohl van Wijngaarden
Ewoud Kohl van Wijngaarden
[test foreman-installer]
Updated to include EL8 to verify https://projects.theforeman.org/issues/29189. It will still fail and https://github.com/theforeman/foreman-installer/pull/493 is probably needed since that module isn't really receiving any attention. MongoDB on Debian 10 is not...
Marking back as draft since some migrations were added and this is out of date now. It should really add a check to ensure everything is in line.
> Does this make sense? Yes! > Are the things being caught useful? Not entirely since we expect changes. Probably better to have a file with the expected output so...
Yes, that would be much cleaner. https://github.com/theforeman/kafo/pull/284 would do that. I'm not sure what would be best considering cherry picks so I'm leaving this open for now.
https://github.com/theforeman/foreman-installer/pull/585 for comparison.
Note that this is because `factory_class.declarations()` is used, which only lists explicitly declared parameters.
I agree that FactoryBoy needs something similar to `declarations()` to get all overrideable attributes, like `accepted_arguments()`. Then it's trivial for pytest-factoryboy to use that and it should work.
I don't know SQLAlchemy + FactoryBoy now since we use Django models, but FactoryBoy already accepts the model parameters even if they're not specified on the factory. It's just that...
I created an issue to extend FactoryBoy.