Ewoud Kohl van Wijngaarden
Ewoud Kohl van Wijngaarden
> > Small detail, but this looks good. > > I don't think that's correct, because I took my regex directly from Stdlib:HTTPSUrl > > https://github.com/puppetlabs/puppetlabs-stdlib/blob/main/types/httpsurl.pp > > Which is:...
> It looks like the Stdlib:HTTPSUrl allows that for some reason? Possibly an oversight and nobody ran into problems because of it.
Because of https://github.com/puppetlabs/puppetlabs-apache/pull/2289#discussion_r948196017. You must name it according to the conventions so the loader finds it, so `types/mod_proxy_protocol.pp`.
> This is a draft because apache::mod::expires creates a config by default, which is probably not what we want out of the box. I'd like to see a discusion on...
Did you forget to push?
> If my logic there is correct, I think we don't need to modify it now. Just to clarify: if `_require` is `nil` then it does `nil !~ /unmanaged/i`, but...
I included https://github.com/puppetlabs/puppetlabs_spec_helper/pull/351 now.
Would you be able to put a PR together to fix this?
Github points on in that commit that it's included in the v3.1.0 git tag. That would be my first try.
To me the biggest questions is why Beaker serializes so much. It feels to me that it's serializing way too much. For example, a logger? A password prompt? Feels to...