Ewoud Kohl van Wijngaarden

Results 1155 comments of Ewoud Kohl van Wijngaarden

> I wanted to see how much work this would be, and the impact and whether it was small enough to warrant consideration for Foreman 3.0 changes. I am however,...

For now I'm moving this back to a draft status, while I'd still love to see it happen.

Derp, it was `< 11` in our packaging and I copied that. Updated to 10.

Ruby tests fail due to Rails 6.1.6.1.

You may also want to set tftp to false until https://github.com/theforeman/puppet-foreman_proxy/pull/602 is merged.

I wonder if this file is still needed. IMHO it was always a workaround for failing to specify correct permissions in modules. I'd consider to remove it

Back in the day we had a pipeline with umask 077 for the regular installer to verify. I think that would be a good test.

We've been talking about idempotency tests. You could do a base run, run it again (and assert nothing changes) and then run it with a different umask (again, asserting nothing...

Kafo still works in the same way: defaults are copied to the answers file. It's just that since Kafo 3, Hiera is considered while determining defaults. I thought I wrote...

https://github.com/theforeman/kafo#default-values does go over this, but it's a bit brief on implementation details. The first step it talks about (a static value) is done using puppet-strings. We have a JSON...