foreman-installer icon indicating copy to clipboard operation
foreman-installer copied to clipboard

Published 20 hours ago • verified publisher icon theforeman

Add ForemanGoogle plugin

Open stejskalleos opened this issue 2 years ago • 4 comments

stejskalleos avatar Apr 06 '22 12:04 stejskalleos

This will fail CI until a matching patch in https://github.com/theforeman/puppet-foreman is merged. Once the PR is available, please link it.

ekohl avatar Apr 06 '22 12:04 ekohl

Puppet PR: https://github.com/theforeman/puppet-foreman/pull/1040

stejskalleos avatar Apr 11 '22 06:04 stejskalleos

[test foreman-installer]

ekohl avatar Apr 11 '22 08:04 ekohl

google rpm has been merged, rebased & updated

stejskalleos avatar Oct 13 '22 10:10 stejskalleos

@ekohl PR updated, however rspec ./spec/migration_spec.rb tests are still failing on mismatch with answers, not sure why

stejskalleos avatar Oct 26 '22 13:10 stejskalleos

@ekohl migration files updated but it still fails :/

stejskalleos avatar Oct 26 '22 14:10 stejskalleos

@ekohl and it's :green_apple: !

stejskalleos avatar Oct 31 '22 09:10 stejskalleos

@ekohl https://github.com/theforeman/foreman-installer/pull/815 added

stejskalleos avatar Nov 02 '22 06:11 stejskalleos

Tests are failing on [Librarian] Conflict between theforeman-pulpcore (>= 7.0.1, < 8.0.0) <https://forgeapi.puppet.com/> (from katello-foreman_proxy_content) and theforeman-pulpcore/7.0.0 <https://github.com/theforeman/puppet-pulpcore#master> Could not resolve the dependencies., not sure if it is related to my changes

stejskalleos avatar Nov 02 '22 07:11 stejskalleos

No, that pulpcore failure was because I should have done https://github.com/theforeman/puppet-pulpcore/commit/e124f89c117d221ecd350daf2d0627df4a573531 before merging the other PR.

ekohl avatar Nov 02 '22 13:11 ekohl

@ekohl cool, now it's green again

stejskalleos avatar Nov 02 '22 13:11 stejskalleos