Eric Huss

Results 752 comments of Eric Huss

I'm going to close since this seems to have stalled for a few months. I also don't think this is something that necessarily needs to change. The specific patch versions...

I don't have a strong opinion about the long name. `--cwd` or `--cd` seems more explicit as to what it does, and would lean slightly towards that, but other options...

We had a pretty lengthy discussion about this issue today, but unfortunately didn't come to a direct conclusion. One thing we would like to see is an overview of alternatives...

I think it would be fine to `#[derive(Debug, Clone)]` on `CompileOptions` and `BuildConfig`, and just wrap `rustfix_diagnostic_server` in an `Arc` (as in `rustfix_diagnostic_server: Arc`). Can you say if you ran...

Another minimum thing would be to always show the output if the "start" fails. That often happens when either you pick the wrong start point, or your test itself is...

I think it would be ok to use an explicit path as long as the output-tracking code was kept in sync. Unfortunately my instinct is that might be a little...

> What is the status here? The feature is being stabilized so maybe we should merge the reference changes :) The reference changes have to wait for the stabilization PR...

Ping @crlf0710 Do you think you'd be able to address the comments here?

Yea, I wanted to get this ready for when it lands again. The stabilization should not have been done without this being ready, but I let it fall through the...

I'm concerned about broken symlinks leading to a broken build or broken links. Would something like ignoring those paths (#1908) work for you?