reference
reference copied to clipboard
rust-lang
Add trait_upcasting related languages changes
What is the status here? The feature is being stabilized so maybe we should merge the reference changes :)
What is the status here? The feature is being stabilized so maybe we should merge the reference changes :)
The reference changes have to wait for the stabilization PR to merge.
Sorry I didn't get to reviewing this earlier, I did not know it was being stabilized, and I tend to not prioritize pre-stabilization PRs when it seems like they are a long way off from being stabilized.
This feature is being reverted so we should not land this PR.
That said, it'd still be good to have the PR ready for when this gets stabilized for real. :)
Yea, I wanted to get this ready for when it lands again. The stabilization should not have been done without this being ready, but I let it fall through the cracks.
Do you think you'd be able to address the comments here?
Frankly, i don't feel i have enough skill of writing to address the comments here(especially as i'm not a English-speaker). I can deal with "add XXX after YYY"-style of comments well, but i can't deal with the "This should mention" and "worth stating explicitly" style of comments.