Eric Huss

Here is a test that illustrates the problem with having multiple versions: ```rust #[cargo_test] fn same_name_version_changed() { // Illustrates having two path packages with the same name, but different versions....

Thanks! I moved the suggested test to `path.rs` since it is unrelated to patching. I'm still not 100% confident with that final `None` return, but I can't think of any...

@bors retry

That's really unfortunate, I hadn't thought about that. I'm wondering if a compromise would be to only adjust permissions on packages that don't have a build script? I don't know...

@weihanglo Asked about how to do a crater run to test the impact of changing the readonly status. The rough steps are: 1. In your clone of cargo, make the...

I'm not certain the best approach for this, but one idea is to pass in the workspace root directory to cargo-as-rustc as an environment variable (we use `__CARGO_FIX_` prefixes for...

Another issue that came up is that some suggestions are for the standard library if you have the rust-src component installed. Those should be protected as well. See https://github.com/rust-lang/rust/issues/88514#issuecomment-2043469384

Preferably I would like to get this fixed in rustc instead. I *think* it should not be too hard. rustc knows if spans are for the local crate. I'm wondering...

The Cargo Team discussed this a bit, and here are some questions or thoughts from that discussion: * There were some concerns that the proposed solution seemed to be ELF-specific....

As mentioned in the unresolved section, profile rustflags get applied to build scripts. You can override that with: ```toml [profile.dev.build-override] rustflags = [] ``` Also, I might suggest using the...