Eric Huss

Results 775 comments of Eric Huss

See also https://github.com/rust-lang/rust/issues/62865

I think it would be ok to use `cfg!(windows)` to choose the STATUS_ACCESS_VIOLATION exit code instead of 101.

I've been thinking about this for a while. Some thoughts: ## Backwards compatibility I'm a little concerned about the scenario where someone has a custom test harness that relies on...

I think it is supposed to be a joke. IOW, "aliasing is not found" because it is currently not defined.

This seems like a duplicate of #8140? Is there something different here, or can it be closed?

Hm, I'm not quite following how it is different. We can reword the title if that helps. That issue is specifically about having `host:` in the hash, which affects reproducibility....

Offhand I am not aware of any automation to support generating the summary file, I think you will need to do it manually or create a script to do it.

I have transferred this to the crates.io issue tracker. Errors are generated on the server side, so any sort of "consolidate multiple errors" will need to be implemented here.

It looks like you are using `cargo build` and `cargo vendor` manually. The rust project is not intended to be used that way. The `./x` script is the intended mechanism...

Seems fine overall. It looks like it adds about 15MB to the overall doc size, which should be fine for now (the docs are currently about 724MB), but we may...