Eric Huss

Results 742 comments of Eric Huss

I would prefer to not use regular expressions to translate the links. Can the translation be done in `adjust_links` or somewhere like that?

Can you say more what is "weird" about it?

> but I can't see any code change requests and even reviews for this PR. Am I missing something and what should I response/clarify? I'm so sorry. I had a...

Unfortunately this PR looks like it still needs a lot of work. I started a longer review, but I just don't currently have the time to work through all of...

Thanks for taking a look at this. I've been thinking of going the multiple-package route in the 0.5 release. Unfortunately I don't think a change like this can be made...

#1234. I haven't given it too much thought recently. I think it would be good to identify the use cases ("preprocessor user", "renderer user", non-CLI driver (like [rustbook](https://github.com/rust-lang/rust/tree/master/src/tools/rustbook)), and try...

Changing the config structure is a breaking change, so you'll need to find a different short-term solution. Can you say what the differences are between mathjax 2 and 3? Why...

> You are wrong here. I didn't break anything. I have proposed new functionality that does not conflict with existing configurations. Ah, apologies, I saw that `mathjax-support` was removed in...

I think it would be great to have a more stripped-down core library. I'm uncertain if it is necessary to make it a separate crate. My concern is that adds...

Sorry, I don't have time to review all PRs. Just a quick scan of this PR, there are a number of issues: * The inclusion of the extra stuff needs...