Edward Faulkner

Results 555 comments of Edward Faulkner

Apparently the YUIDoc parser is sloppy enough to not care about the difference between JS and TS. This seems to be working fine: https://github.com/ember-learn/ember-cli-addon-docs-yuidoc/compare/master...ef4:ts

I agree with the comments above that tsdoc looks like a good bet. I started trying to integrate it just now, but decided I don't have time to do it,...

Thanks for tracking this. In my ideal design, the controls would clearly be global and would effect even what appears in the left sidebar, since whole classes could disappear.

I think the travis key _is_ read only by default, but that doesn't mean you can't use the existing instructions to paste it in as a deploy key and check...

Update: the switch to script deploys worked great, and properly fails your build if the deploy fails. The use of the built-in Travis key turns out not to be a...

I started debugging this. The problem is related to how bananas dummy apps are. Some combination of dependencies is causing embroider to get confused about which thing is the app....

Please try this again with ember-auto-import 2.4.2.

Ugh, yes, it looks like my change fixed the embroider case but broke the classic case.

Locating an element via its class and then asserting its text is very different from locating an element via its text and then asserting its class. Consider an example like...

IMO it very much depends which semantics you're trying to encode in your particular test. If you're trying to always target an exact component implementation, sure, add a dedicated selector....