qunit-dom icon indicating copy to clipboard operation
qunit-dom copied to clipboard

Update embroider monorepo to v1 (major)

Open renovate[bot] opened this issue 3 years ago • 6 comments

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@embroider/compat 0.48.1 -> 1.8.3 age adoption passing confidence
@embroider/core 0.48.1 -> 1.8.3 age adoption passing confidence
@embroider/macros 0.48.1 -> 1.8.3 age adoption passing confidence
@embroider/webpack 0.48.1 -> 1.8.3 age adoption passing confidence

Release Notes

embroider-build/embroider

v1.8.3

Compare Source

:bug: Bug Fix
  • compat
    • #​1231 Followup to "Detect addons with customized treeForMethod names" (@​ef4)
:house: Internal
Committers: 1

v1.8.2

Compare Source

:bug: Bug Fix
  • compat, shared-internals
Committers: 1

v1.8.1

Compare Source

:bug: Bug Fix
:memo: Documentation
Committers: 4

v1.8.0

Compare Source

:rocket: Enhancement
  • addon-dev, core, shared-internals
:bug: Bug Fix
Committers: 4

v1.7.1

Compare Source

:bug: Bug Fix
Committers: 1

v1.7.0

Compare Source

:rocket: Enhancement
:bug: Bug Fix
:memo: Documentation
:house: Internal
Committers: 6

v1.6.0

Compare Source

:rocket: Enhancement
  • addon-dev, compat, core, hbs-loader, shared-internals, webpack
:bug: Bug Fix
:memo: Documentation
:house: Internal
Committers: 5

v1.5.0

Compare Source

:rocket: Enhancement
  • util
:bug: Bug Fix
Committers: 2

v1.4.0

Compare Source

:rocket: Enhancement
:bug: Bug Fix
Committers: 2

v1.3.0

Compare Source

:rocket: Enhancement
:bug: Bug Fix
:memo: Documentation
:house: Internal
Committers: 10

v1.2.0

Compare Source

:rocket: Enhancement
  • compat
  • macros
    • #​1119 Reuse the loc of the macroMaybeAttrs hashes for the created attributes (@​Windvis)
:memo: Documentation
:house: Internal
Committers: 3

v1.1.0

Compare Source

:rocket: Enhancement
:bug: Bug Fix
:memo: Documentation
:house: Internal
Committers: 9

v1.0.0

Compare Source

Declaring this as 1.0 to signifiy general level of stability and to give us more flexibility to distinguish minor and patch releases.

:internal: Internal
  • Renamed default branch from master to main.
:bug: Bug Fix
Committers: 1

v0.50.2

Compare Source

:bug: Bug Fix
Committers: 1

v0.50.1

Compare Source

:bug: Bug Fix
  • core
    • #​1074 Ensure babelFilter config comes from fully qualified @embroider/core path in Stage 2 (@​krisselden)
  • compat, core, macros, shared-internals
    • #​1070 Ensure dependencySatisfies only considers actual dependencies (includes a fix for invalid results within monorepo scenarios) (@​NullVoxPopuli)
Committers: 2

v0.50.0

Compare Source

:rocket: Enhancement
  • addon-shim, core, shared-internals
:bug: Bug Fix
  • compat
Committers: 1

v0.49.0

Compare Source

:rocket: Enhancement
:bug: Bug Fix
:house: Internal
Committers: 6

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • [ ] If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by Mend Renovate. View repository job log here.

renovate[bot] avatar Jan 19 '22 17:01 renovate[bot]

@scalvert @rwjblue @ef4 any ideas how we can make this PR green?

Turbo87 avatar May 19 '22 11:05 Turbo87

I started debugging this. The problem is related to how bananas dummy apps are. Some combination of dependencies is causing embroider to get confused about which thing is the app. It thinks the dummy app is not the app, which means it doesn't look at the dummy app's devDependencies, which means it thinks the dummy app doesn't have ember-auto-import, which means the qunit import isn't allowed to resolve to an NPM package.

ef4 avatar May 19 '22 14:05 ef4

hmm okay, so the easiest way forward would be to not use a dummy app, but a monorepo with an app instead?

Turbo87 avatar May 20 '22 09:05 Turbo87

Please try this again with ember-auto-import 2.4.2.

ef4 avatar May 21 '22 22:05 ef4

hmm, CI still red, though potentially for different reasons

Turbo87 avatar May 22 '22 07:05 Turbo87

Ugh, yes, it looks like my change fixed the embroider case but broke the classic case.

ef4 avatar May 22 '22 15:05 ef4