Edward Faulkner

Results 555 comments of Edward Faulkner

@srb- default params are working now, for both ArrowExpressions and FunctionExpresion: `$ cat sample.coffee` ``` coffee class Foo extends Bar doIt: (a=1, b=2, c...)-> super("yay", a, b, c) demo =...

I haven't yet, but I'm planning to use it to help me port a significant production codebase from coffeescript to ES6. This is admittedly a lower bar than getting it...

Sure, happy to rebase in anticipation of merge, as soon as I have the test suite stabilized.

I have a separate tool for safely porting the comments across, using source mapping as a guide. I should get around to publishing it. This PR is still definitely a...

I had to shift focus to other things, anyone is welcome to take it and run with it. The status is the same as my last comment: it's already useful...

I incorporated this PR into [my ES6 branch](https://github.com/michaelficarra/CoffeeScriptRedux/pull/344), so I can piggyback off the `super` keyword. It's working pretty well. Demo: `$ cat sample.coffee` ``` coffee class Foo extends Bar...

https://github.com/michaelficarra/CoffeeScriptRedux/issues/299 looks like the same bug, although this example is broader -- no destructuring is needed to trigger the bug.

I was interpreting the error as "while disambiguating a structure that starts at line 1, col 1, I hit an error `offset` bytes ahead of that point. I haven't looked...

Yeah, if that's the intent of `offset`, `line`, and `column` then we probably do have a bug in pegjs. Skimming their repo just now it does look like it's supposed...