Edward Faulkner

Results 555 comments of Edward Faulkner

Oops, sorry, somehow I looked right at it and didn't see it. 😛

I think we can make the argument that this is a bugfix instead of breaking change because people were *already* experiencing peer dep warnings and/or failures depending on their package...

It was pointed out to me that this really is probably breaking, because it's not the addition to `peerDependencies` that is the big problem, it's the removal from `dependencies`.

I still think we should do it, we can make this ember-cli-babel 8. I know a traditional reason not to do a major release here was to save it for...

Discussed with ember-cli core team and agreed to merge this, once we see it run CI. For some reason that hasn't happened yet. Investigating. Also, the plan to release this...

I use a custom mocha reporter by placing the reporter itself in `tests/helpers/reporter.js`, and then in test-helper.js I do: ``` js import Reporter from './helpers/reporter'; mocha.reporter(Reporter); ```

@mmahalwy I've been using https://github.com/ef4/better-mocha-html-reporter

I don't think this will break anything _as long as_ Promise.then is using proper microtask timing. But I don't think all our supported browsers have correct microtask timing when you...

I think https://github.com/embroider-build/embroider/pull/1205 addressed this by improving embroider's compatibility.

@lennyburdette if you can share a reproduction of *the same* template getting processed both ways (with and without an absolute path in `moduleName`, that would be a helpful bug report....