Edward Faulkner

Results 555 comments of Edward Faulkner

It's bad for the same reason that ECB mode is bad: patterns in the data remain visible as patterns in the ciphertext. The only difference is that in this case...

This is broken for object literals too. If you substitute: ```js function example() { let value = { a: 1 }; value.a = 2; return value; } ``` `path.evaluate()` says...

You can be confident only if there are no other references to the binding in between initialization and return: ```js function() { let value = { a: 1 }; return...

> Embroider isn't officially supported. Embroider the build tool isn't yet, but [embroider the addon format](https://github.com/emberjs/rfcs/blob/master/text/0507-embroider-v2-package-format.md) is, and we're talking about addon behavior here. So it would be good to...

To be clear, it's not imminent. I don't think anybody needs to rush into doing anything, and no support is going to get dropped any time soon. But taking the...

Just adding these dependencies to a new app doesn't reproduce this problem. If you can figure out a minimal reproduction I can take a look.

Right now I've been using https://github.com/ember-cli/ember-welcome-page/pull/346 as the working example. I just updated it with a list of open TODOs, some of which are needed docs.

Yes, and @rwjblue has convinced me that we should push for the monorepo version as the default. The main benefit of not using a monorepo has historically been the ability...

It would not be correct for an addon to have ember-source in `dependencies` because that would bring an extra copy of ember-source into applications, and there should really only be...

The problem is this doesn't reliably fix the problem. It assumes that hoisting will work out and that some deeply nested packages will be able to resolve the app's copy...