Eric Erhardt

Results 266 comments of Eric Erhardt

> Can be closed as duplicate of #5730 as 5730 will remove the dependency on protobuf, and that'll indirectly fix this issue too. What about any other size issues beyond...

> That particular one is not in hot path. Its only called when ActivitySource is created, not for every Activity creation. The size of the app isn't affected whether it...

@EricJohnson327 - any thoughts here?

@kasperk81 - can you log an issue in dotnet/runtime?

I'm in support of exposing outputs that we know there are scenarios for consuming them. I wouldn't expose them all "just because" since we are still making changes in these...

@mmitche - are there any concerns with making .md changes in the 9.0 branch of arcade? I assume this is OK. For background context - this raises markdown linter errors...

qdrant is done: https://github.com/dotnet/aspire/blob/9a68b552f847caa62ebc612e4dc23160c29e36d5/tests/Aspire.Hosting.Qdrant.Tests/QdrantFunctionalTests.cs#L23-L63

CosmosDB has both EF and non-EF functional tests in [Extract EventHubs and Cosmos Tests from EndToEndTests and into Aspire.Hosting.Azure.Tests (dotnet/aspire#6538)](https://github.com/dotnet/aspire/pull/6538).

@captainsafia - can you take a look at this? At least disable it so it doesn't affect others' PRs.