Eric Erhardt

Results 266 comments of Eric Erhardt

> I've been talking a closer look at this from a security perspective, and I think we need to make some changes. When I run this locally the args are...

> When I run this locally the args are visble in the dashboard without any obfuscation (unlike environment variables). @drewnoakes @adamint - is it possible to mark command line arguments...

> Frustratingly Redis Stack actually makes use of a REDIS_ARGS environment variable which can use to specify the -requirepass [password] argument. Yeah, I was wondering if it would make sense...

I've revived this PR with the latest code in `main`. The intent is to get this change into 9.1. The [initial concerns](https://github.com/dotnet/aspire/pull/4642#issuecomment-2292514163) that blocked this change should no longer be...

> is it possible to specify the user for Redis? Or is that unnecessary in this scenario, with Aspire just using the default user? Right now, no. We are just...

> Do we mark this as a breaking change? I don't think this is a breaking change. We can log it in the changelog, but I'm not sure exactly what...

Thank you, @Alirexaa for your continued contributions!

Thanks for the contribution, @The3G. Can you add some tests for this change?

Looks like the new test is currently failing.

Looks like the test is still failing.